linux-kernel - Re: [PATCH] parport: Add support for the WCH384 4S multi-IO card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEdQ38EcNTgfFaGVzVS9nFbBorVCKsCSuZvWDFakn6PfMCLDWA@mail.gmail.com>
Date:   Fri, 6 Jul 2018 08:32:46 -0700
From:   Matt Turner <mattst88@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Sergej Pupykin <ml@...gej.pp.ru>
Subject: Re: [PATCH] parport: Add support for the WCH384 4S multi-IO card

On Thu, Jul 5, 2018 at 3:17 PM Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
>
> Hi Matt,
>
> On Sat, May 26, 2018 at 12:35:23PM -0700, Matt Turner wrote:
> > This Multi-IO card has one serial 16550-like serial connectors. Here's
> > the lspci output, after this commit is applied:
> >
> > 01:00.0 Serial controller [0700]: Device [1c00:3470] (rev 10) (prog-if 05 [16850])
> >         Subsystem: Device [1c00:3470]
> >         Flags: fast devsel, IRQ 16
> >         I/O ports at e000 [size=256]
> >         Memory at f0100000 (32-bit, prefetchable) [size=32K]
> >         I/O ports at e100 [size=4]
> >         Expansion ROM at f7d00000 [disabled] [size=32K]
> >         Capabilities: [60] Power Management version 3
> >         Capabilities: [68] MSI: Enable- Count=1/32 Maskable+ 64bit+
> >         Capabilities: [80] Express Legacy Endpoint, MSI 00
> >         Capabilities: [100] Advanced Error Reporting
> >         Kernel driver in use: parport_serial
> >
> > This card was already added to the blacklist of 8250_pci.c in commit
> > 72a3c0e4e662 ("tty: Add support for the WCH384 4S multi-IO card").
> >
> > Cc: Sergej Pupykin <ml@...gej.pp.ru>
> > Signed-off-by: Matt Turner <mattst88@...il.com>
> > ---
> > It looks like CH355_4S is similarly missing, but I don't have hardware
> > to test.
> >
> > This commit makes me wonder if I'm missing something -- how could
> > anything have worked after commit 72a3c0e4e662 without support in
> > parport_serial?
> >
>
> Is the patch still needed to be applied? After Andy's patch to tty tree,
> the device (0x1c00, 0x3470) will be probed by 8250_pci.c.

Yes, Andy's patch replaces this one. It can be discarded.

Thanks!
Matt