linux-kernel - Re: [PATCH] arm64: add ARM64-specific support for flatmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86D2343D-83C6-4E96-83A5-55C617EF7687@cisco.com>
Date:   Fri, 6 Jul 2018 16:35:16 +0000
From:   "Nikunj Kela (nkela)" <nkela@...co.com>
To:     Will Deacon <will.deacon@....com>
CC:     Catalin Marinas <catalin.marinas@....com>,
        "xe-kernel@...ernal.cisco.com" <xe-kernel@...ernal.cisco.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: add ARM64-specific support for flatmem

Will modify the patch to remove ARM64. Every other architecture kept def_bool y for it so I followed the same for ARM64 too. 

Thanks,
-Nikunj

On 7/6/18, 9:00 AM, "Will Deacon" <will.deacon@....com> wrote:

    Please write a commit message for your patch.
    
    On Fri, Jul 06, 2018 at 08:56:27AM -0700, Nikunj Kela wrote:
    > Cc: xe-kernel@...ernal.cisco.com
    > Cc: Nikunj Kela <nkela@...co.com>
    > Signed-off-by: Nikunj Kela <nkela@...co.com>
    > ---
    >  arch/arm64/Kconfig | 4 ++++
    >  1 file changed, 4 insertions(+)
    > 
    > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
    > index 42c090c..5e791f0 100644
    > --- a/arch/arm64/Kconfig
    > +++ b/arch/arm64/Kconfig
    > @@ -775,6 +775,10 @@ config ARCH_SPARSEMEM_DEFAULT
    >  config ARCH_SELECT_MEMORY_MODEL
    >  	def_bool ARCH_SPARSEMEM_ENABLE
    >  
    > +config ARCH_FLATMEM_ENABLE
    > +	def_bool y
    > +	depends on ARM64 && !NUMA
    
    We don't need ARM64 here. I'm also not sure about the def_bool y, this seems
    like a pretty niche thing to enable.
    
    Will