linux-kernel - Re: [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153089827550.143105.2506072427444330254@swboyd.mtv.corp.google.com>
Date:   Fri, 06 Jul 2018 10:31:15 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>,
        linux-kernel@...r.kernel.org
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        rnayak@...eaurora.org, linux-arm-msm@...r.kernel.org,
        Will Deacon <will.deacon@....com>, smohanad@...eaurora.org,
        bjorn.andersson@...aro.org, edubezval@...il.com,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, vivek.gautam@...eaurora.org,
        Catalin Marinas <catalin.marinas@....com>,
        andy.gross@...aro.org, linux-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes

Quoting Amit Kucheria (2018-07-02 05:44:09)
> SDM845 has two tsens blocks, one with 13 sensors and the other with 8
> sensors.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index cdaabeb..edf8505 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -221,6 +221,22 @@
>                         #interrupt-cells = <2>;
>                 };
>  
> +               tsens0: tsens@...2000 {

These unit addresses should match the first reg property, not the second
one.

> +                       compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2";
> +                       reg = <0xc263000 0x1ff>, /* TM */
> +                             <0xc222000 0x1ff>; /* SROT */
> +                       #qcom,sensors = <13>;
> +                       #thermal-sensor-cells = <1>;
> +               };
> +
> +               tsens1: tsens@...3000 {
> +                       compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2";
> +                       reg = <0xc265000 0x1ff>, /* TM */
> +                             <0xc223000 0x1ff>; /* SROT */
> +                       #qcom,sensors = <8>;