linux-kernel - Re: [PATCH] [v2] sbitmap, scsi/target: add seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180706205800.GD25954@vader>
Date:   Fri, 6 Jul 2018 13:58:00 -0700
From:   Omar Sandoval <osandov@...ndov.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Jens Axboe <axboe@...nel.dk>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        linux-scsi@...r.kernel.org,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        Omar Sandoval <osandov@...com>, Ming Lei <ming.lei@...hat.com>,
        Paolo Valente <paolo.valente@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward
 declaration

On Fri, Jul 06, 2018 at 10:19:07PM +0200, Arnd Bergmann wrote:
> The target core runs into a warning in the linux/sbitmap.h
> file in some configurations:
> 
> In file included from include/target/target_core_base.h:7,
>                  from drivers/target/target_core_fabric_lib.c:41:
> include/linux/sbitmap.h:331:46: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                               ^~~~~~~~
> 
> In general, headers should not depend on others being included first,
> so this fixes it with a forward declaration for that struct name, but
> we probably want to merge the patch through the scsi tree to help
> bisection.
> 
> Fixes: 10e9cbb6b531 ("scsi: target: Convert target drivers to use sbitmap")

Reviewed-by: Omar Sandoval <osandov@...com>

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v2: move declaration to the start of the header, as suggested by Bart
> ---
>  include/linux/sbitmap.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/sbitmap.h b/include/linux/sbitmap.h
> index e6539536dea9..804a50983ec5 100644
> --- a/include/linux/sbitmap.h
> +++ b/include/linux/sbitmap.h
> @@ -23,6 +23,8 @@
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  
> +struct seq_file;
> +
>  /**
>   * struct sbitmap_word - Word in a &struct sbitmap.
>   */
> -- 
> 2.9.0
>