linux-kernel - Re: [PATCH] thunderbolt: fix small typo in variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180707110951.GL2534@lahna.fi.intel.com>
Date:   Sat, 7 Jul 2018 14:09:51 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     nathan.d.ciobanu@...ux.intel.com, linux-kernel@...r.kernel.org,
        michael.jamet@...el.com, andreas.noever@...il.com
Subject: Re: [PATCH] thunderbolt: fix small typo in variable name

On Sat, Jul 07, 2018 at 10:19:50AM +0200, Lukas Wunner wrote:
> On Tue, Jun 26, 2018 at 04:34:20PM -0700, nathan.d.ciobanu@...ux.intel.com wrot> Fixes small variable name typo and the associated
> > checkpatch spelling warning
> > 
> > Signed-off-by: Nathan Ciobanu <nathan.d.ciobanu@...ux.intel.com>
> > ---
> >  drivers/thunderbolt/tb_regs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
> > index 5d94142afda6..693b0353c3fe 100644
> > --- a/drivers/thunderbolt/tb_regs.h
> > +++ b/drivers/thunderbolt/tb_regs.h
> > @@ -202,7 +202,7 @@ struct tb_regs_port_header {
> >  	/* DWORD 5 */
> >  	u32 max_in_hop_id:11;
> >  	u32 max_out_hop_id:11;
> > -	u32 __unkown4:10;
> > +	u32 __unknown4:10;
> >  	/* DWORD 6 */
> >  	u32 __unknown5;
> >  	/* DWORD 7 */
> 
> This is not an improvement.  The bitfield is marked unknown because
> its meaning hasn't been reverse-engineered yet.  But you work for
> Intel, presumably you don't have to reverse-engineer the bitfield's
> meaning because you know it or can find out about it.
> 
> So please submit a patch that changes the name to the bitfield's
> actual meaning.

It is an improvement since it fixes what it says (the typo). Besides the
patch is already applied.