lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Jul 2018 20:53:09 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Platform Driver <platform-driver-x86@...r.kernel.org>, Darren Hart <dvhart@...radead.org>, Andy Shevchenko <andy@...radead.org> Cc: LKML <linux-kernel@...r.kernel.org>, Azael Avalos <coproscefalo@...il.com> Subject: [PATCH] platform/x86/toshiba_acpi.c: fix defined but not used build warnings From: Randy Dunlap <rdunlap@...radead.org> Fix a build warning in toshiba_acpi.c when CONFIG_PROC_FS is not enabled by marking the unused function as __maybe_unused. ../drivers/platform/x86/toshiba_acpi.c:1685:12: warning: 'version_proc_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap <rdunlap@...radead.org> Cc: Azael Avalos <coproscefalo@...il.com> Cc: platform-driver-x86@...r.kernel.org Cc: Darren Hart <dvhart@...radead.org> Cc: Andy Shevchenko <andy@...radead.org> --- drivers/platform/x86/toshiba_acpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-next-20180706.orig/drivers/platform/x86/toshiba_acpi.c +++ linux-next-20180706/drivers/platform/x86/toshiba_acpi.c @@ -34,6 +34,7 @@ #define TOSHIBA_ACPI_VERSION "0.24" #define PROC_INTERFACE_VERSION 1 +#include <linux/compiler.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/moduleparam.h> @@ -1682,7 +1683,7 @@ static const struct file_operations keys .write = keys_proc_write, }; -static int version_proc_show(struct seq_file *m, void *v) +static int __maybe_unused version_proc_show(struct seq_file *m, void *v) { seq_printf(m, "driver: %s\n", TOSHIBA_ACPI_VERSION); seq_printf(m, "proc_interface: %d\n", PROC_INTERFACE_VERSION);
Powered by blists - more mailing lists