linux-kernel - Re: Crypto Fixes for 4.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwe3HrgMBUhyHC7kAOCvp31S4kpAqDSFQ+BQY6r=WBiiA@mail.gmail.com>
Date:   Sun, 8 Jul 2018 11:31:16 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: Crypto Fixes for 4.18

On Sun, Jul 8, 2018 at 9:20 AM Herbert Xu <herbert@...dor.apana.org.au> wrote:
>
> - Add missing RETs in x86 aegis/morus.

Side note - I queried earlier during the discussion about this: how
was this code taken despite having clearly never tested on _anything_?

That's a serious question. Code that simply has never had any testing
AT ALL should not have gotten in.

The use of 'int3' in padding showed the issue, but I don't believe the
code could possibly have worked with the nops and fallthroughs.

               Linus