linux-kernel - Re: [PATCH] Fix the oldconfig target rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM5PR0701MB26575A5A1FBEDFC9127110BAE4450@AM5PR0701MB2657.eurprd07.prod.outlook.com>
Date:   Sun, 8 Jul 2018 11:13:21 +0000
From:   Bernd Edlinger <bernd.edlinger@...mail.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix the oldconfig target rule

On 07/08/18 12:41, Masahiro Yamada wrote:
> 2018-07-08 17:09 GMT+09:00 Bernd Edlinger <bernd.edlinger@...mail.de>:
>> On 07/08/18 08:31, Bernd Edlinger wrote:
>>> The next make after an oldconfig reads in the outdated
>>> include/config/auto.conf which can kill the make before
>>> it is able to call the syncconfig target.
>>>
>>> $ make defconfig
>>> *** Default configuration is based on 'x86_64_defconfig'
>>> $ make
>>> scripts/kconfig/conf  --syncconfig Kconfig
>>> Makefile:936: *** "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y,
>>> please install libelf-dev, libelf-devel or elfutils-libelf-devel".  Stop.
>>>
>>> $ sed -i s/CONFIG_UNWINDER_ORC=y// .configs
>>> $ make oldconfig
>>> Choose kernel unwinder
>>>> 1. ORC unwinder (UNWINDER_ORC) (NEW)
>>>     2. Frame pointer unwinder (UNWINDER_FRAME_POINTER)
>>> choice[1-2?]: 2
>>> $ make
>>> Makefile:936: *** "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y,
>>> please install libelf-dev, libelf-devel or elfutils-libelf-devel".  Stop.
>>>
>>> With this patch oldconfig and similar targets like
>>> menuconfig call syncconfig to avoid this failure.
>>>
>>> Signed-off-by: Bernd Edlinger <bernd.edlinger@...mail.de>
>>> ---
>>>    scripts/kconfig/Makefile | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
>>> index a3ac2c9..ef34275 100644
>>> --- a/scripts/kconfig/Makefile
>>> +++ b/scripts/kconfig/Makefile
>>> @@ -62,6 +62,7 @@ PHONY += $(simple-targets)
>>>
>>>    $(simple-targets): $(obj)/conf
>>>        $< $(silent) --$@ $(Kconfig)
>>> +    $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
>>
>> On second thought, removing the auto.conf might be sufficient:
>> $(Q)rm -f include/config/auto.conf include/config/auto.conf.cmd
>>
>> Would you prefer that?
> 
> No.
> 
> My suggestion is this:
> https://patchwork.kernel.org/patch/10513065/
> 
> 

Ok, thanks a lot.

I tried your patch and it seems reasonable me.
(nit: In the change log entry s/RETPORINE/RETPOLINE/)

However the warning is gone as well, which was probably done
on purpose to push people to install the elf library.

I wonder in general if the test using HOSTCC misses
somehow the possibility that there may be a CROSS_COMPLILE ?


Bernd.