linux-kernel - Re: [PATCH] powerpc: Replaced msleep with usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201807100423.0p0r9QGb%fengguang.wu@intel.com>
Date:   Tue, 10 Jul 2018 04:07:50 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Daniel Klamt <eleon@...0n.de>
Cc:     kbuild-all@...org, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de,
        Daniel Klamt <eleon@...0n.de>,
        Bjoern Noetel <bjoern@...ak3r.de>
Subject: Re: [PATCH] powerpc: Replaced msleep with usleep_range

Hi Daniel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc4 next-20180709]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Klamt/powerpc-Replaced-msleep-with-usleep_range/20180709-231913
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/sysdev/xive/native.c: In function 'xive_native_configure_irq':
>> arch/powerpc/sysdev/xive/native.c:113:2: error: expected ';' before '}' token
     }
     ^

vim +113 arch/powerpc/sysdev/xive/native.c

243e2511 Benjamin Herrenschmidt 2017-04-05  103  
243e2511 Benjamin Herrenschmidt 2017-04-05  104  int xive_native_configure_irq(u32 hw_irq, u32 target, u8 prio, u32 sw_irq)
243e2511 Benjamin Herrenschmidt 2017-04-05  105  {
243e2511 Benjamin Herrenschmidt 2017-04-05  106  	s64 rc;
243e2511 Benjamin Herrenschmidt 2017-04-05  107  
243e2511 Benjamin Herrenschmidt 2017-04-05  108  	for (;;) {
243e2511 Benjamin Herrenschmidt 2017-04-05  109  		rc = opal_xive_set_irq_config(hw_irq, target, prio, sw_irq);
243e2511 Benjamin Herrenschmidt 2017-04-05  110  		if (rc != OPAL_BUSY)
243e2511 Benjamin Herrenschmidt 2017-04-05  111  			break;
c332c793 Daniel Klamt           2018-07-09  112  		usleep_range(1000, 1100)
243e2511 Benjamin Herrenschmidt 2017-04-05 @113  	}
243e2511 Benjamin Herrenschmidt 2017-04-05  114  	return rc == 0 ? 0 : -ENXIO;
243e2511 Benjamin Herrenschmidt 2017-04-05  115  }
5af50993 Benjamin Herrenschmidt 2017-04-05  116  EXPORT_SYMBOL_GPL(xive_native_configure_irq);
5af50993 Benjamin Herrenschmidt 2017-04-05  117  
243e2511 Benjamin Herrenschmidt 2017-04-05  118  

:::::: The code at line 113 was first introduced by commit
:::::: 243e25112d06b348f087a6f7aba4bbc288285bdd powerpc/xive: Native exploitation of the XIVE interrupt controller

:::::: TO: Benjamin Herrenschmidt <benh@...nel.crashing.org>
:::::: CC: Michael Ellerman <mpe@...erman.id.au>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (23386 bytes)