[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFBinCA6gZ9fw0yGvs_FWuGoZG-d2CL2R5qYp3_u1T=Atn8tgA@mail.gmail.com>
Date: Mon, 9 Jul 2018 23:46:20 +0200
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: khilman@...libre.com
Cc: sudeep.holla@....com, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, marc.zyngier@....com,
tglx@...utronix.de
Subject: Re: [PATCH 1/2] Revert "tick: Prefer a lower rating device only if
it's CPU local device"
On Mon, Jul 9, 2018 at 8:24 PM Kevin Hilman <khilman@...libre.com> wrote:
>
> On Mon, Jul 9, 2018 at 8:45 AM Sudeep Holla <sudeep.holla@....com> wrote:
> >
> > This reverts commit 1332a90558013ae4242e3dd7934bdcdeafb06c0d.
> >
> > The original issue was not because of incorrect checking of cpumask for
> > both new and old tick device. It was incorrectly analysed was due to the
> > misunderstanding of the comment and misinterpretation of the return
> > value from tick_check_preferred. The main issue is with the clockevent
> > driver that sets the cpumask to cpu_all_mask instead of cpu_possible_mask.
> >
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
>
> Tested-by: Kevin Hilman <khilman@...libre.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> And verified to fix a regression on the 32-bit ARM platform mesion8b-odroidc1.
I also tested it on Meson8b as well as Meson8m2
Regards
Martin
Powered by blists - more mailing lists