linux-kernel - Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mc4s6tJw6dAHYCPQdsPox9V8sBTqY3LHi5XMWALwOZdyA@mail.gmail.com>
Date:   Mon, 9 Jul 2018 10:52:44 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     "Chiang, AlanX" <alanx.chiang@...el.com>
Cc:     "Robert P. J. Day" <rpjday@...shcourse.ca>,
        Rob Herring <robh@...nel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "Yeh, Andy" <andy.yeh@...el.com>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "tfiga@...omium.org" <tfiga@...omium.org>,
        "jcliang@...omium.org" <jcliang@...omium.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property

2018-07-09 5:12 GMT+02:00 Chiang, AlanX <alanx.chiang@...el.com>:
> Hi Robert,
>
>> -----Original Message-----
>> From: Robert P. J. Day [mailto:rpjday@...shcourse.ca]
>> Sent: Friday, July 6, 2018 4:24 AM
>> To: Rob Herring <robh@...nel.org>
>> Cc: Chiang, AlanX <alanx.chiang@...el.com>; linux-i2c@...r.kernel.org; Yeh,
>> Andy <andy.yeh@...el.com>; sakari.ailus@...ux.intel.com;
>> andriy.shevchenko@...ux.intel.com; Shevchenko, Andriy
>> <andriy.shevchenko@...el.com>; Mani, Rajmohan
>> <rajmohan.mani@...el.com>; andy.shevchenko@...il.com;
>> tfiga@...omium.org; jcliang@...omium.org; brgl@...ev.pl;
>> mark.rutland@....com; arnd@...db.de; gregkh@...uxfoundation.org;
>> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org
>> Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width
>> property
>>
>> On Thu, 5 Jul 2018, Rob Herring wrote:
>>
>> > On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@...el.com wrote:
>> > > From: Alan Chiang <alanx.chiang@...el.com>
>> > >
>> > > The AT24 series chips use 8-bit address by default. If some chips
>> > > would like to support more than 8 bits, the at24 driver should be
>> > > added the compatible field for specfic chips.
>> > >
>> > > Provide a flexible way to determine the addressing bits through
>> > > address-width in this patch.
>> > >
>> > > Signed-off-by: Alan Chiang <alanx.chiang@...el.com>
>> > > Signed-off-by: Andy Yeh <andy.yeh@...el.com>
>> > > Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
>> > >
>> > > ---
>> > > since v1:
>> > > -- Remove the address-width field in the example.
>> > > since v2:
>> > > -- Remove redundant space.
>> > > since v3:
>> > > -- Add Acked-by.
>> > >
>> > > ---
>> > >  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>> > >  1 file changed, 2 insertions(+)
>> >
>> > Reviewed-by: Rob Herring <robh@...nel.org>
>>
>>   "... should be added the compatible field ..."??
>>
>> rday
>
> Maybe I should modify the sentence as below that makes it clear.
> "The compatible field should be added in the at24.c for specific chips.".
>
> I quote Andy's words in patch v2:
> "The current at24 driver has no address width support, thus, reusing same
> (allocated) IDs (non-DT case) is hard."
>
> This is the reason that I submitted the patch.
>
> Thanks
>

Make it something like:

Currently the only way to use a variant of a supported model with
a different address width is to define a new compatible string and the
corresponding chip data structure.

Provide a flexible way to specify the size of the address pointer by
defining a new property: address-width.

Best regards,
Bartosz Golaszewski

>>
>> --
>>
>> ==========================================================
>> ==============
>> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>>                   http://crashcourse.ca/dokuwiki
>>
>> Twitter:                                       http://twitter.com/rpjday
>> LinkedIn:                               http://ca.linkedin.com/in/rpjday
>> ==========================================================
>> ==============