linux-kernel - Re: [PATCH 1/4] i2c: imx: Fix reinit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y3ekahpr.fsf@gmail.com>
Date:   Mon, 09 Jul 2018 11:20:16 +0200
From:   Esben Haabendal <esben.haabendal@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     linux-i2c@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Lucas Stach <l.stach@...gutronix.de>,
        Clemens Gruber <clemens.gruber@...ruber.com>,
        Michail Georgios Etairidis <m.etairidis@...k-ipc.com>,
        linux-kernel@...r.kernel.org, Yuan Yao <yao.yuan@...escale.com>,
        linux-imx@....com
Subject: Re: [PATCH 1/4] i2c: imx: Fix reinit_completion() use

Uwe Kleine-König <u.kleine-koenig@...gutronix.de> writes:

> Cc += Yuan Yao who authored DMA support and the NXP team.
>
> On Wed, May 23, 2018 at 11:56:20AM +0200, Esben Haabendal wrote:
>> From: Esben Haabendal <eha@...f.com>
>> 
>> Make sure to call reinit_completion() before dma is started to avoid race
>> condition where reinit_compleition() is called after complete() and before
>
> s/compleition/completion/

Will fix in v2.

>
>> wait_for_completion_timeout().
>
> Is this a theoretical problem, or did it trigger on your side?

I thought I did trigger it, but haven't been able to reproduce.
So it might or might not be theoretical based on my experiences, but it
does look like something that can (and thus should) trigger sometimes.

/Esben