[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180709092827.GA2841@intel.com>
Date: Mon, 9 Jul 2018 10:28:27 +0100
From: Eric Engestrom <eric.engestrom@...el.com>
To: Daniel Vetter <daniel.vetter@...ll.ch>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org,
Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
DRI Development <dri-devel@...ts.freedesktop.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH 04/12] cpufreq: use for_each_if
On Monday, 2018-07-09 10:36:42 +0200, Daniel Vetter wrote:
> Avoids the inverted condition compared to the open coded version.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: linux-pm@...r.kernel.org
> ---
> include/linux/cpufreq.h | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 882a9b9e34bc..f2028c229b96 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry(pos, table) \
> for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
>
> /*
> * cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq
> @@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry_idx(pos, table, idx) \
> cpufreq_for_each_entry_idx(pos, table, idx) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency == CPUFREQ_ENTRY_INVALID)
Should be `!=` there ^
>
>
> int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
> --
> 2.18.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists