linux-kernel - Re: [PATCH] i2c-hid: Fix "incomplete report" noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1807091428570.997@cbobk.fhfr.pm>
Date:   Mon, 9 Jul 2018 14:29:07 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Jason Andryuk <jandryuk@...il.com>
cc:     linux-kernel@...r.kernel.org, john-s-84@....net,
        stable@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] i2c-hid: Fix "incomplete report" noise

On Fri, 22 Jun 2018, Jason Andryuk wrote:

> Commit ac75a041048b ("HID: i2c-hid: fix size check and type usage")
> started writing messages when the ret_size is <= 2 from i2c_master_recv.
> However, my device i2c-DLL07D1 returns 2 for a short period of time
> (~0.5s) after I stop moving the pointing stick or touchpad.  It varies,
> but you get ~50 messages each time which spams the log hard.
> [  95.925055] i2c_hid i2c-DLL07D1:01: i2c_hid_get_input: incomplete report (83/2)
> 
> This has also been observed with a i2c-ALP0017.
> [ 1781.266353] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2)
> 
> Only print the message when ret_size is totally invalid and less than 2
> to cut down on the log spam.
> 
> Reported-by: John Smith <john-s-84@....net>
> Cc: stable@...r.kernel.org
> Signed-off-by: Jason Andryuk <jandryuk@...il.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs