linux-kernel - Re: [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180709161019.GN129942@google.com>
Date:   Mon, 9 Jul 2018 09:10:19 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Eduardo Valentin <edubezval@...il.com>,
        smohanad@...eaurora.org,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        lakml <linux-arm-kernel@...ts.infradead.org>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes

On Mon, Jul 09, 2018 at 09:34:55PM +0530, Amit Kucheria wrote:
> On Mon, Jul 9, 2018 at 9:31 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
> > On Mon, Jul 09, 2018 at 04:56:51PM +0530, Amit Kucheria wrote:
> >> On Wed, Jul 4, 2018 at 3:18 AM, Matthias Kaehlcke <mka@...omium.org> wrote:
> >> > Hi,
> >> >
> >> > On Mon, Jul 02, 2018 at 06:14:09PM +0530, Amit Kucheria wrote:
> >> >> SDM845 has two tsens blocks, one with 13 sensors and the other with 8
> >> >> sensors.
> >> >>
> >> >> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> >> >> ---
> >> >>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++++++++++
> >> >>  1 file changed, 16 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> >> >> index cdaabeb..edf8505 100644
> >> >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> >> >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> >> >> @@ -221,6 +221,22 @@
> >> >>                       #interrupt-cells = <2>;
> >> >>               };
> >> >>
> >> >> +             tsens0: tsens@...2000 {
> >> >> +                     compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2";
> >> >> +                     reg = <0xc263000 0x1ff>, /* TM */
> >> >> +                           <0xc222000 0x1ff>; /* SROT */
> >> >> +                     #qcom,sensors = <13>;
> >> >> +                     #thermal-sensor-cells = <1>;
> >> >> +             };
> >> >> +
> >> >> +             tsens1: tsens@...3000 {
> >> >> +                     compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2";
> >> >> +                     reg = <0xc265000 0x1ff>, /* TM */
> >> >> +                           <0xc223000 0x1ff>; /* SROT */
> >> >> +                     #qcom,sensors = <8>;
> >> >> +                     #thermal-sensor-cells = <1>;
> >> >> +             };
> >> >> +
> >> >>               spmi_bus: spmi@...0000 {
> >> >>                       compatible = "qcom,spmi-pmic-arb";
> >> >>                       reg = <0xc440000 0x1100>,
> >> >
> >> > I tested this series on an SDM845 board. Temperatures can be read from
> >> > the tsens0 sensors, however for tsens1 sensors I get:
> >> >
> >> > cat temp
> >> > cat: temp: No data available
> >> >
> >> > TRDY_READY_BIT set when reading TRDY_OFFSET in get_temp_tsens_v2().
> >> > Unfortunately I currently have no documentation of the registers or the
> >> > thermal sensors in general and couldn't investigate further.
> >> >
> >> > Any idea what could be the problem?
> >>
> >> Strangely enough, I'm seeing this now after rebuilding my integration
> >> branch to test some other bits.
> >>
> >> I've sent another version with this patch removed while I investigate
> >> this. Could you check if you're able to read all 8 sensors with v5?
> >
> > With v6 all sensors can be read, thanks!
> 
> Great! Would it be OK to add your Tested-by tag?

Yep