linux-kernel - Re: [PATCH for 4.18 0/6] Restartable Sequences updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jul 2018 14:04:44 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-api <linux-api@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Boqun Feng <boqun.feng@...il.com>,
        Andy Lutomirski <luto@...capital.net>,
        Dave Watson <davejwatson@...com>, Paul Turner <pjt@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Russell King <linux@....linux.org.uk>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Andi Kleen <andi@...stfloor.org>,
        Chris Lameter <cl@...ux.com>, Ben Maurer <bmaurer@...com>,
        rostedt <rostedt@...dmis.org>,
        Josh Triplett <josh@...htriplett.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Joel Fernandes <joelaf@...gle.com>
Subject: Re: [PATCH for 4.18 0/6] Restartable Sequences updates

----- On Jul 8, 2018, at 5:03 PM, Mathieu Desnoyers mathieu.desnoyers@...icios.com wrote:

> Following the recent discussion thread [1] about rseq uapi, here is
> a set of updates submitted for integration into 4.18. Those change all
> rseq __get_user/__put_user for get_user/put_user as discussed.

Considering that ppc32 does not implement 64-bit get_user(), I will re-spin
the whole series using __copy_from_user/__copy_to_user() to replace
__get_user()/__put_user() to load/store the 64-bit rseq_cs field.

I'm aiming for a minimal change at this stage of the rc cycle.

Thanks,

Mathieu

> 
> Thanks,
> 
> Mathieu
> 
> [1]
> https://lkml.kernel.org/r/20180702223143.4663-1-mathieu.desnoyers@efficios.com
> 
> Mathieu Desnoyers (6):
>  rseq: use __u64 for rseq_cs fields, validate user inputs
>  rseq: use get_user/put_user rather than __get_user/__put_user
>  rseq: uapi: update uapi comments
>  rseq: uapi: declare rseq_cs field as union, update includes
>  rseq: remove unused types_32_64.h uapi header
>  rseq/selftests: cleanup: update comment above rseq_prepare_unload
> 
> include/uapi/linux/rseq.h           | 102 ++++++++++++++++++++----------------
> include/uapi/linux/types_32_64.h    |  50 ------------------
> kernel/rseq.c                       |  36 ++++++++-----
> tools/testing/selftests/rseq/rseq.h |  24 ++++++---
> 4 files changed, 97 insertions(+), 115 deletions(-)
> delete mode 100644 include/uapi/linux/types_32_64.h
> 
> --
> 2.11.0

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com