linux-kernel - Re: [PATCH] checkpatch: Require author Signed-off-by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <400ec2706f9239ae1819a60df0ddcd39e067d927.camel@perches.com>
Date:   Tue, 10 Jul 2018 16:46:05 -0700
From:   Joe Perches <joe@...ches.com>
To:     Pavel Machek <pavel@....cz>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andy Whitcroft <apw@...onical.com>, jgg@...lanox.com,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linus Walleij <linus.walleij@...aro.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Require author Signed-off-by

On Wed, 2018-07-11 at 00:08 +0200, Pavel Machek wrote:
> On Tue 2018-07-10 22:50:14, Geert Uytterhoeven wrote:
> > Hi Pavel,
> > 
> > On Tue, Jul 10, 2018 at 10:47 PM Pavel Machek <pavel@....cz> wrote:
> > > > Print an error if none of the Signed-off-by lines cover the patch
> > > > author.
> > > 
> > > Is it good idea? Signed-off-by system was _not_ meant to prevent
> > > submission of third party patches.
> > 
> > My main motivation is catching accidentally forgotten Sobs.
> > It's still up to you to submit or accept a patch that triggers
> > checkpatch errors.
> 
> Should it be at warning level, then, or explicitely saying this is
> okay if you are not patch author?

Yes to both.