linux-kernel - Re: [PATCH 1/2] drivers: core: Don't try to use a dead glue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwWq1pMzKbkgTN9f9srSHubq+tKKPHwZazqt8ODD3btNQ@mail.gmail.com>
Date:   Tue, 10 Jul 2018 16:55:37 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Joel Stanley <joel@....id.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] drivers: core: Don't try to use a dead glue_dir

On Tue, Jul 10, 2018 at 4:32 PM Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
>
> > I like that fix, which should make this patch obsolete, right?
>
> Yes, for that specific issue, but Linus seemed to think patch 1 was the
> "right thing to do" regardless...

I would definitely prefer either a kobject_get_unless_zero() or a
warning if it is ever zero.

The fact that right now it silently can do known bad things, and then
causes odd corruption _later_, is not good.

            Linus