linux-kernel - Re: [PATCH] f2fs: Keep alloc_valid_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55de7e3a-9c21-4601-6ee7-83ba97a2509e@huawei.com>
Date:   Tue, 10 Jul 2018 14:17:31 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Daniel Rosenberg <drosen@...gle.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
CC:     <linux-kernel@...r.kernel.org>, <kernel-team@...roid.com>
Subject: Re: [PATCH] f2fs: Keep alloc_valid_block_count in sync

On 2018/7/10 11:32, Daniel Rosenberg wrote:
> If we attempt to request more blocks than we have room for, we try to
> instead request as much as we can, however, alloc_valid_block_count
> is not decremented to match the new value, allowing it to drift higher
> until the next checkpoint. This always decrements it when the requested
> amount cannot be fulfilled.
> 
> Signed-off-by: Daniel Rosenberg <drosen@...gle.com>

Good catch, thanks for the fixing. :)

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,