[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ee4acd3d-e31f-747b-d3a8-adbe0fb46d83@analog.com>
Date: Tue, 10 Jul 2018 08:46:24 +0200
From: Michael Hennerich <michael.hennerich@...log.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
Lee Jones <lee.jones@...aro.org>,
Daniel Thompson <daniel.thompson@...aro.org>,
"Jingoo Han" <jingoohan1@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
CC: <dri-devel@...ts.freedesktop.org>, <linux-fbdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through
On 09.07.2018 23:51, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Acked-by: Michael Hennerich <michael.hennerich@...log.com>
> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 16119bd..f1dc41c 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
> switch (ADP8860_MANID(reg_val)) {
> case ADP8863_MANUFID:
> data->gdwn_dis = !!pdata->gdwn_dis;
> + /* fall through */
> case ADP8860_MANUFID:
> data->en_ambl_sens = !!pdata->en_ambl_sens;
> break;
>
--
Greetings,
Michael
--
Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne
Powered by blists - more mailing lists