linux-kernel - Re: [PATCH 2/3] vsprintf: Remove incorrect EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180709221214.167e0ed0@vmware.local.home>
Date:   Mon, 9 Jul 2018 22:12:14 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Theodore Ts'o <tytso@....edu>, Petr Mladek <pmladek@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] vsprintf: Remove incorrect EXPORT_SYMBOL

On Tue, 10 Jul 2018 10:25:18 +1000
"Tobin C. Harding" <me@...in.cc> wrote:

> Recently boot variable 'debug_boot_weak_hash' was added (by me).  In a
> classic case of cargo cult programming the novice developer added a
> macro call to EXPORT_SYMBOL().  This is wrong and was pointed out on
> LKML.  As pointed out EXPORT_SYMBOL() cannot be used on static
> variables.
> 
> Remove incorrect usage of macro EXPORT_SYMBOL()
> 
> Fixes: bfe80ed3d7c76 ("vsprintf: add command line option debug_boot_weak_hash")
> Signed-off-by: Tobin C. Harding <me@...in.cc>

Revieved-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Hmm, not sure if Ted rebases his trees or not, but if he does, he could
also fold this into that commit.

-- Steve

> ---
>  lib/vsprintf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index cdc2c355dff5..fe834a201f3d 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1655,7 +1655,6 @@ static DEFINE_STATIC_KEY_TRUE(not_filled_random_ptr_key);
>  
>  /* Make pointers available for printing early in the boot sequence. */
>  static int debug_boot_weak_hash __ro_after_init;
> -EXPORT_SYMBOL(debug_boot_weak_hash);
>  
>  static int __init debug_boot_weak_hash_enable(char *str)
>  {