linux-kernel - Re: [GIT PULL] SCSI fixes for 4.18-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx9iTm2rZqL1jo_mhAp7EQ8tHhU6MFCSG7XdqAxY_vUGw@mail.gmail.com>
Date:   Tue, 10 Jul 2018 10:49:42 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jann Horn <jannh@...gle.com>
Cc:     James Bottomley <James.Bottomley@...senpartnership.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux SCSI List <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] SCSI fixes for 4.18-rc3

On Tue, Jul 10, 2018 at 10:36 AM Jann Horn <jannh@...gle.com> wrote:
>
> AFAICS it does mean that if two processes use /dev/sg* - the first one
> in a way that passes sg_check_file_access(), the second one in a way
> that gets blocked for whatever reason -, the pr_err_once() will fire
> for the process that's working and not fire for the one that got
> blocked. But if nobody should be using that interface anyway, I guess
> that's not a practical concern.

Right. I don't expect it to trigger at all, and the "working" program
should be fixed too, because I want for us to be able to just remove
that idiotic direct access thing.

> Also, the device is called /dev/sg%d with %d being sdp->index.

I guess I could make it at least say that, although it's not like "one
of them would be ok, but /dev/sd3 is right out".

             Linus