linux-kernel - Re: [PATCH] xfs_attr_leaf: use swap macro in xfs_attr3_leaf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180711174421.GH32415@magnolia>
Date:   Wed, 11 Jul 2018 10:44:21 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs_attr_leaf: use swap macro in xfs_attr3_leaf_rebalance

On Mon, Jul 09, 2018 at 11:12:47AM -0500, Gustavo A. R. Silva wrote:
> Make use of the swap macro and remove some unnecessary variables.
> This makes the code easier to read and maintain. Also, reduces the
> stack usage.
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Looks ok, will test...
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  fs/xfs/libxfs/xfs_attr_leaf.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> index 76e9004..ec0bf96 100644
> --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> @@ -1570,17 +1570,10 @@ xfs_attr3_leaf_rebalance(
>  	 */
>  	swap = 0;
>  	if (xfs_attr3_leaf_order(blk1->bp, &ichdr1, blk2->bp, &ichdr2)) {
> -		struct xfs_da_state_blk	*tmp_blk;
> -		struct xfs_attr3_icleaf_hdr tmp_ichdr;
> +		swap(blk1, blk2);
>  
> -		tmp_blk = blk1;
> -		blk1 = blk2;
> -		blk2 = tmp_blk;
> -
> -		/* struct copies to swap them rather than reconverting */
> -		tmp_ichdr = ichdr1;
> -		ichdr1 = ichdr2;
> -		ichdr2 = tmp_ichdr;
> +		/* swap structures rather than reconverting them */
> +		swap(ichdr1, ichdr2);
>  
>  		leaf1 = blk1->bp->b_addr;
>  		leaf2 = blk2->bp->b_addr;
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html