linux-kernel - Re: [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC

Open Source and information security mailing list archives

Date:   Wed, 11 Jul 2018 16:10:18 +0800
From:   Jian Hu <jian.hu@...ogic.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        <robh@...nel.org>
CC:     <jbrunet@...libre.com>, Neil Armstrong <narmstrong@...libre.com>,
        <qianggui.song@...ogic.com>, <devicetree@...r.kernel.org>,
        <sboyd@...nel.org>, <khilman@...libre.com>,
        <mturquette@...libre.com>, <yixun.lan@...ogic.com>,
        <linux-kernel@...r.kernel.org>, <bo.yang@...ogic.com>,
        <qiufang.dai@...ogic.com>, <linux-arm-kernel@...ts.infradead.org>,
        <carlo@...one.org>, <linux-amlogic@...ts.infradead.org>,
        <sunny.luo@...ogic.com>, <linux-clk@...r.kernel.org>,
        <xingyu.chen@...ogic.com>
Subject: Re: [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A
 SoC


On 2018/7/10 5:57, Martin Blumenstingl wrote:
> adding Rob Herring so it doesn't get lost on the devicetree mailing list
> 
> On Mon, Jul 9, 2018 at 1:13 PM Jian Hu <jian.hu@...ogic.com> wrote:
>>
>> Add new binding for Meson-G12A SoC Everything-Else part
>>
>> Signed-off-by: Jian Hu <jian.hu@...ogic.com>
>> ---
>>   Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
>> index e950599..0833006 100644
>> --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
>> @@ -9,6 +9,7 @@ Required Properties:
>>                  "amlogic,gxbb-clkc" for GXBB SoC,
>>                  "amlogic,gxl-clkc" for GXL and GXM SoC,
>>                  "amlogic,axg-clkc" for AXG SoC.
>> +               "amlogic,g12a-clkc" for G12A SoC.
> should this be "amlogic,meson-g12a-clkc" instead?
> that would make it consistent with virtually all other bindings which
> use the schema "amlogic,meson<chip>-<ip-block>" (where chip is 8, 8b,
> 8m2, -gxbb, -gxl, ...)
> 
> see also: $ grep -R "amlogic," Documentation/devicetree/bindings/
> 
Which type should we choose,have a discussion?
.compatible = "amlogic,g12a-clkc or
.compatible = "amlogic,meson-g12a-clkc
>>
>>   - #clock-cells: should be 1.
>>
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 
> .
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives