linux-kernel - Re: [PATCH] 9p/net/protocol.c: return -ENOMEM when kmalloc() failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B455C87.6090507@huawei.com>
Date:   Wed, 11 Jul 2018 09:25:27 +0800
From:   jiangyiwen <jiangyiwen@...wei.com>
To:     piaojun <piaojun@...wei.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        <ericvh@...il.com>, <rminnich@...dia.gov>, <lucho@...kov.net>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <v9fs-developer@...ts.sourceforge.net>
Subject: Re: [PATCH] 9p/net/protocol.c: return -ENOMEM when kmalloc() failed

On 2018/7/11 8:43, piaojun wrote:
> We should return -ENOMEM to upper user when kmalloc failed to indicate
> accurate errno.
> 
> Signed-off-by: Jun Piao <piaojun@...wei.com>

Reviewed-by: Yiwen Jiang <jiangyiwen@...wei.com>

> ---
>  net/9p/protocol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/9p/protocol.c b/net/9p/protocol.c
> index 931ea00..4a1e1dd 100644
> --- a/net/9p/protocol.c
> +++ b/net/9p/protocol.c
> @@ -156,7 +156,7 @@ static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size)
> 
>  				*sptr = kmalloc(len + 1, GFP_NOFS);
>  				if (*sptr == NULL) {
> -					errcode = -EFAULT;
> +					errcode = -ENOMEM;
>  					break;
>  				}
>  				if (pdu_read(pdu, *sptr, len)) {
>