linux-kernel - Re: [PATCH] clk: core: Potentially free connection id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b809427e9b922ba41efafb20a97e0698e9cd3d0.camel@nxp.com>
Date:   Wed, 11 Jul 2018 10:17:10 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     "mperttunen@...dia.com" <mperttunen@...dia.com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "cyndis@...si.fi" <cyndis@...si.fi>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
Subject: Re: [PATCH] clk: core: Potentially free connection id

On Wed, 2018-07-11 at 11:21 +0300, Mikko Perttunen wrote:
> Patch "clk: core: Copy connection id" made it so that the connector
> id (con_id) is kstrdup_const'ed to cater to drivers that pass non-
> constant connection ids. The patch added the corresponding
> kfree_const
> to __clk_free_clk, but struct clk's can be freed also via __clk_put.
> Add the kfree_const call to __clk_put and add comments to both
> functions to remind that the logic in them should be kept in sync.
> 
> Fixes: 253160a8ad06 ("clk: core: Copy connection id")
> Signed-off-by: Mikko Perttunen <mperttunen@...dia.com>

Yes, sorry I missed this.

Reviewed-by: Leonard Crestez <leonard.crestez@....com>

Maybe a static __clk_free_mem function could be created instead of
comments asking to keep things in sync? But there are only 2 lines so
it's fine.