linux-kernel - Re: [PATCH v5 3/7] KVM: arm64: Support dirty page tracking for PUD hugepages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd3ab2b5-a0c3-3847-a048-94bc6de481ff@arm.com>
Date:   Wed, 11 Jul 2018 14:03:02 +0100
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     Punit Agrawal <punit.agrawal@....com>, kvmarm@...ts.cs.columbia.edu
Cc:     linux-arm-kernel@...ts.infradead.org, marc.zyngier@....com,
        christoffer.dall@....com, linux-kernel@...r.kernel.org,
        will.deacon@....com, Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH v5 3/7] KVM: arm64: Support dirty page tracking for PUD
 hugepages

On 09/07/18 15:41, Punit Agrawal wrote:
> In preparation for creating PUD hugepages at stage 2, add support for
> write protecting PUD hugepages when they are encountered. Write
> protecting guest tables is used to track dirty pages when migrating
> VMs.
> 
> Also, provide trivial implementations of required kvm_s2pud_* helpers
> to allow sharing of code with arm32.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
> Reviewed-by: Christoffer Dall <christoffer.dall@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> ---
>   arch/arm/include/asm/kvm_mmu.h   | 16 ++++++++++++++++
>   arch/arm64/include/asm/kvm_mmu.h | 10 ++++++++++
>   virt/kvm/arm/mmu.c               | 11 +++++++----
>   3 files changed, 33 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/include/asm/kvm_mmu.h b/arch/arm/include/asm/kvm_mmu.h
> index d095c2d0b284..c23722f75d5c 100644
> --- a/arch/arm/include/asm/kvm_mmu.h
> +++ b/arch/arm/include/asm/kvm_mmu.h
> @@ -80,6 +80,22 @@ void kvm_clear_hyp_idmap(void);
>   
>   #define kvm_pmd_mkhuge(pmd)	pmd_mkhuge(pmd)
>   
> +/*
> + * The following kvm_*pud*() functionas are provided strictly to allow

nit: s/functionas/functions/

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>