linux-kernel - Re: [PATCH] fs: Fix double prealloc_shrinker() in sget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24667.1531321044@warthog.procyon.org.uk>
Date:   Wed, 11 Jul 2018 15:57:24 +0100
From:   David Howells <dhowells@...hat.com>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     dhowells@...hat.com, viro@...iv.linux.org.uk,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] fs: Fix double prealloc_shrinker() in sget_fc()

Kirill Tkhai <ktkhai@...tuozzo.com> wrote:

> diff --git a/fs/super.c b/fs/super.c
> index 13647d4fd262..47a819f1a300 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -551,7 +551,7 @@ struct super_block *sget_fc(struct fs_context *fc,
>  	hlist_add_head(&s->s_instances, &s->s_type->fs_supers);
>  	spin_unlock(&sb_lock);
>  	get_filesystem(s->s_type);
> -	register_shrinker(&s->s_shrink);
> +	register_shrinker_prepared(&s->shrinker);
>  	return s;
>  }
>  EXPORT_SYMBOL(sget_fc);
> 

I already folded in a fix from Eric for this, but Al hasn't pulled the updated
tree yet.

David