linux-kernel - Re: [PATCH v2] selftests/android: initialize heap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53f02d65-9a91-2661-3052-d46032389e3a@kernel.org>
Date:   Wed, 11 Jul 2018 10:17:37 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Li Zhijian <lizhijian@...fujitsu.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Pintu Agarwal <pintu.ping@...il.com>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v2] selftests/android: initialize heap_type to avoid
 compiling warning

On 07/10/2018 08:08 PM, Li Zhijian wrote:
> root@...lkp-nex04-8G-7 ~/linux-v4.18-rc2/tools/testing/selftests/android# make
> make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
> make[1]: Entering directory '/root/linux-v4.18-rc2/tools/testing/selftests/android/ion'
> gcc  -I. -I../../../../../drivers/staging/android/uapi/ -I../../../../../usr/include/ -Wall -O2 -g    ionapp_export.c ipcsocket.c ionutils.c   -o ionapp_export
> ionapp_export.c: In function 'main':
> ionapp_export.c:91:2: warning: 'heap_type' may be used uninitialized in
> this function [-Wmaybe-uninitialized]
>   printf("heap_type: %ld, heap_size: %ld\n", heap_type, heap_size);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> CC: Shuah Khan <shuah@...nel.org>
> CC: Pintu Agarwal <pintu.ping@...il.com>
> Signed-off-by: Li Zhijian <lizhijian@...fujitsu.com>
> ---
>  tools/testing/selftests/android/ion/ionapp_export.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/android/ion/ionapp_export.c b/tools/testing/selftests/android/ion/ionapp_export.c
> index a944e72..b5fa0a2 100644
> --- a/tools/testing/selftests/android/ion/ionapp_export.c
> +++ b/tools/testing/selftests/android/ion/ionapp_export.c
> @@ -51,6 +51,7 @@ int main(int argc, char *argv[])
>  
>  	heap_size = 0;
>  	flags = 0;
> +	heap_type = ION_HEAP_TYPE_SYSTEM;
>  
>  	while ((opt = getopt(argc, argv, "hi:s:")) != -1) {
>  		switch (opt) {
> 

Thanks. Applied to linux-kselftest next after updating the commit message

"Initialize heap_type to ION_HEAP_TYPE_SYSTEM to avoid "used uninitialized"
compiler warning. heap_type gets used after initialization, this change is
to just keep the compiler happy."

thanks,
-- Shuah