linux-kernel - Re: [PATCH] scsi: switch to scsi-mq by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVOSssuveZDN185FUYpjX1i0ma59Cn30XBSJ1dAHDKLnLQ@mail.gmail.com>
Date:   Thu, 12 Jul 2018 00:35:17 +0800
From:   Ming Lei <tom.leiming@...il.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Hannes Reinecke <hare@...e.de>,
        Bart Van Assche <Bart.VanAssche@...disk.com>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: switch to scsi-mq by default

On Wed, Jul 11, 2018 at 4:31 PM, Adrian Hunter <adrian.hunter@...el.com> wrote:
> On 11/07/18 05:52, Martin K. Petersen wrote:
>>
>> Johannes,
>>
>>> It has been more than one year since we tried to change the default
>>> from legacy to multi queue in SCSI with commit c279bd9e406 ("scsi:
>>> default to scsi-mq"). But due to issues with suspend/resume and
>>> performance problems it had been reverted again with commit
>>> cbe7dfa26eee ("Revert "scsi: default to scsi-mq"").
>>>
>>> In the meantime there have been a substantial amount of performance
>>> improvements and suspend/resume got fixed as well, thus we can
>>> re-enable scsi-mq without a significant performance penalty.
>>
>> Applied to 4.19/scsi-queue, thanks!
>>
>
> But there is no runtime pm support, is there?  I tried enabling runtime PM
> for UFS SCSI devices with scsi-mq and it didn't work, which is a regression.

I just posted one RFC patchset for supporting runtime PM on scsi_mq, and
looks it works in my test on usb-storage.

https://marc.info/?l=linux-block&m=153132657922233&w=2

thanks,
Ming Lei