linux-kernel - Re: linux-next: build warning after merge of the scsi-mkp tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180712143057.49bfcab5@canb.auug.org.au>
Date:   Thu, 12 Jul 2018 14:30:57 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     James Bottomley <James.Bottomley@...senPartnership.com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <jth@...nel.org>
Subject: Re: linux-next: build warning after merge of the scsi-mkp tree

Hi all,

On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/spinlock_types.h:18:0,
>                  from include/linux/spinlock.h:82,
>                  from drivers/scsi/libfc/fc_rport.c:61:
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>                                              ^
> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>   struct fc_rport_priv *rdata;
>                         ^~~~~
> 
> Introduced by commit
> 
>   ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
> 
> It is actually complaining about function fc_rport_recv_plogi_req()
> (presumably it is being inlined) and this looks like an actual bug :-(

This warning now appears after the merge of the scsi tree.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped