linux-kernel - Re: [PATCH] wimax/i2400m: remove redundant variables ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Jul 2018 22:54:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     inaky.perez-gonzalez@...el.com, linux-wimax@...el.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wimax/i2400m: remove redundant variables ack_status,
 bcf and protocol

From: Colin King <colin.king@...onical.com>
Date: Mon,  9 Jul 2018 13:23:13 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> Variables ack_status, bcf and protocol are being assigned but are
> never used hence they are redundant and can be removed.
> 
> Also declare ack_type as unsigned int rather than unsigned to clean
> up a checkpatch warning.
> 
> Cleans up clang warnings:
> warning: variable 'ack_status' set but not used [-Wunused-but-set-variable]
> warning: variable 'bcf' set but not used [-Wunused-but-set-variable]
> warning: variable 'protocol' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

This is simple enough that I'll just apply this directly, thanks
Colin.