linux-kernel - Re: [PATCH 04/31] usb: usbssp: Added USBSSP platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180712062139.GH20905@kroah.com>
Date:   Thu, 12 Jul 2018 08:21:39 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     linux-usb@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
        linux-kernel@...r.kernel.org, ltyrala@...ence.com,
        adouglas@...ence.com
Subject: Re: [PATCH 04/31] usb: usbssp: Added USBSSP platform driver

On Thu, Jul 12, 2018 at 06:47:01AM +0100, Pawel Laszczak wrote:
> This patch adds platform driver that is entry point for loading and
> unloading usbssp.ko modules.
> It also adds information about this driver to drivers/usb/Kconfig
> and drivers/usb/Makefile files and create Kconfig and Makefile
> files in drivers/usb/usbssp directory.
> 
> Patch also adds template for some function ivokked from
> usbssp_plat.c file. These function will be implemented in next patches.
> 
> This patch also introduce usbssp_trb_virt_to_dma that converts
> virtual address of TRB's to DMA address. In this moment this
> function is used only in gadget-trace.h.
> 
> >From this moment the driver can be compiled.
> 
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>

This is a much nicer breakup of the patches than the last series, thanks
for doing it this way.

> --- a/drivers/usb/usbssp/gadget.h
> +++ b/drivers/usb/usbssp/gadget.h
> @@ -9,7 +9,6 @@
>   * A lot of code based on Linux XHCI driver.
>   * Origin: Copyright (C) 2008 Intel Corp.
>   */
> -
>  #ifndef __LINUX_USBSSP_GADGET_H
>  #define __LINUX_USBSSP_GADGET_H
>  

You should have done that in an earlier patch :)

> @@ -1671,6 +1670,21 @@ static inline void usbssp_write_64(struct usbssp_udc *usbssp_data,
>  {
>  	lo_hi_writeq(val, regs);
>  }
> +
> +/* USBSSP Device controller glue */
> +int usbssp_suspend(struct usbssp_udc *usbssp_data, bool do_wakeup);
> +int usbssp_resume(struct usbssp_udc *usbssp_data, bool hibernated);
> +
> +irqreturn_t usbssp_irq(int irq, void *priv);
> +
> +/* USBSSP ring, segment, TRB, and TD functions */
> +dma_addr_t usbssp_trb_virt_to_dma(struct usbssp_segment *seg,
> +		union usbssp_trb *trb);
> +
> +/* USBSSP gadget interface*/
> +int usbssp_gadget_init(struct usbssp_udc *usbssp_data);
> +int  usbssp_gadget_exit(struct usbssp_udc *usbssp_data);

Very odd indentation, don't you think?

> +MODULE_ALIAS("platform:usbss-gadget");
> +MODULE_DESCRIPTION("USBSSP' Device Controller (USBSSP) Driver");
> +MODULE_LICENSE("GPL");

Wrong MODULE_LICENSE() string.  Please read module.h for what these all
should be.

thanks,

greg k-h