linux-kernel - RE: [PATCH 02/31] usb: usbssp: Added some decoding functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR07MB4709D8EB760716D0F9B0F4FBDD590@BYAPR07MB4709.namprd07.prod.outlook.com>
Date:   Thu, 12 Jul 2018 06:28:33 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lukasz Tyrala <ltyrala@...ence.com>,
        Alan Douglas <adouglas@...ence.com>
Subject: RE: [PATCH 02/31] usb: usbssp: Added some decoding functions.

> > This patch add additional functions that converts some fields to string.
> >
> > For example function usbssp_trb_comp_code_string take completion c ode
> > value and return string describing completion code.
> 
> Odd line-wrapping :(
Do you mean additional space character between "c" and "ode"

> And why do you want a string for these things?  Who cares about them?
It will be used in next version of driver. I have plan to add gadget-debugfs.c file.
At this moment this functions can be useful during debugging driver if someone want to display
some debug information. 

Should I remove this function ?
 
> thanks,
> 
> greg k-h