linux-kernel - Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jul 2018 10:52:47 +0300
From:   Aapo Vienamo <avienamo@...dia.com>
To:     Jon Hunter <jonathanh@...dia.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        <devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/7] soc/tegra: pmc: Implement
 tegra_io_pad_is_powered()

On Wed, 11 Jul 2018 16:26:42 +0100
Jon Hunter <jonathanh@...dia.com> wrote:

> On 11/07/18 16:23, Jon Hunter wrote:
> > 
> > On 11/07/18 15:01, Aapo Vienamo wrote:  
> >> Implement a function to query whether a pad is in deep power down mode.  
> > Can you elaborate on why this public function is needed and who will be
> > using this?  
> 
> Or I should say does this need to be public?

It's only called from the pinconf callbacks and exposing it doesn't
indeed make much sense if we intend to replace direct calls to pmc.c
with pinctrl anyway. I'll make it private on the next iteration of the
series.

 -Aapo