lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 12 Jul 2018 17:58:05 +1000
From:   Nicholas Piggin <npiggin@...il.com>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Daniel Klamt <eleon@...0n.de>, benh@...nel.crashing.org,
        linux-kernel@...cs.fau.de, linux-kernel@...r.kernel.org,
        paulus@...ba.org, Bjoern Noetel <bjoern@...ak3r.de>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc: Replaced msleep(x) with
 msleep(OPAL_BUSY_DELAY_MS)

On Thu, 12 Jul 2018 15:46:06 +1000
Michael Ellerman <mpe@...erman.id.au> wrote:

> Daniel Klamt <eleon@...0n.de> writes:
> 
> > Replaced msleep(x) with with msleep(OPAL_BUSY_DELAY_MS)
> > to diocument these sleep is to wait for opal.
> >
> > Signed-off-by: Daniel Klamt <eleon@...0n.de>
> > Signed-off-by: Bjoern Noetel <bjoern@...ak3r.de>  
> 
> Thanks.
> 
> Your change log should be in the imperative mood, see:
> 
>   https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD#n133
> 
> 
> In this case that just means saying "Replace" rather than "Replaced".
> 
> Also the prefix should be "powerpc/xive". You can guess that by doing:
> 
>   $ git log --oneline arch/powerpc/sysdev/xive/native.c
> 
> And notice that the majority of commits use that prefix.
> 
> 
> I've fixed both of those things up for you.

Sorry, just noticed this. I've got a patch which changes the xive stuff
to the "standard" format this will clash with.

               if (rc == OPAL_BUSY_EVENT) {
                       msleep(OPAL_BUSY_DELAY_MS);
                       opal_poll_events(NULL);
               } else if (rc == OPAL_BUSY) {
                       msleep(OPAL_BUSY_DELAY_MS);
               }

If it's already merged that's fine, I can rebase.

Thanks,
Nick

Powered by blists - more mailing lists