linux-kernel - Re: [PATCH] base: core: Remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180712102529.GB10369@sirena.org.uk>
Date:   Thu, 12 Jul 2018 11:25:29 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        pascal paillet <p.paillet@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Benjamin Gaignard <benjamin.gaignard@...com>
Subject: Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

On Thu, Jul 12, 2018 at 11:18:26AM +0200, Benjamin Gaignard wrote:
> 2018-07-12 10:55 GMT+02:00 Greg KH <gregkh@...uxfoundation.org>:

> > Why would a link already exist that is asked to be created again?  What
> > code path causes this?

> It could happen that the link exist because a device use it parent as supplier.
> That case has been describe by Marek in this thread (I forgot to add
> it in the commit message, sorry):
> https://lkml.org/lkml/2018/7/9/356

If we don't remove the warning then we'd need to have some way for
generic code to check if a link that it wants to create exists already
since if more than one thing adds links there's always a chance that two
of them will come up with the same idea for a link.  We could export
device_is_dependent() and have them check that, or add a new flag that
skips the check for example.  This is however probably going to affect a
reasonable percentage of potential users.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)