linux-kernel - Re: [PATCH] extcon: max3355: include mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <ebd7d32f-48f6-1944-00a3-c2743f83b000@samsung.com>
Date:   Thu, 12 Jul 2018 10:31:45 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: max3355: include mod_devicetable.h

On 2018년 07월 12일 10:30, Chanwoo Choi wrote:
> On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
>> Another driver turned up that is missing linux/mod_devicetable.h after
>> the device IDs are split out from linux/platform_device.h:
>>
>> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
>>  static const struct of_device_id max3355_match_table[] = {
>>
>> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>> Greg, please add that to the char-misc tree that already has
>> other related patches.
>> ---
>>  drivers/extcon/extcon-max3355.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
>> index 0aa410836f4e..1335a476bfec 100644
>> --- a/drivers/extcon/extcon-max3355.c
>> +++ b/drivers/extcon/extcon-max3355.c
>> @@ -14,6 +14,7 @@
>>  #include <linux/gpio/consumer.h>
>>  #include <linux/interrupt.h>
>>  #include <linux/module.h>
>> +#include <linux/mod_devicetable.h>
>>  #include <linux/platform_device.h>
>>  
>>  struct max3355_data {
>>
> 
> Applied it. Thanks.
> 

If Greg pick up this patch, I'll drop it from extcon git.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics