lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 12 Jul 2018 16:40:42 +0200
From:   Arnd Bergmann <>
To:     Christoph Hellwig <>
Cc:     Deepa Dinamani <>,
        Thomas Gleixner <>,
        Linux Kernel Mailing List <>,
        y2038 Mailman List <>,
        Linux API <>
Subject: Re: [PATCH v3 7/7] timex: change syscalls to use struct __kernel_timex

On Thu, Jul 12, 2018 at 10:29 AM, Christoph Hellwig <> wrote:
> On Fri, Jul 06, 2018 at 10:42:47PM -0700, Deepa Dinamani wrote:
>> -#ifdef CONFIG_COMPAT
>> -
>>  COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
>>                      struct compat_timex __user *, utp)
>>  {
>> @@ -1187,10 +1183,6 @@ COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
>>       return err;
>>  }
>> -#endif
> And this unconditionally defines clock_adjtime, but doesn't actually
> seem to add callers, which looks rather odd.  Same for other bits
> in the patch.

It really just moves compat_sys_clock_adjtime() into the same
#ifdef CONFIG_COMPAT_32BIT_TIME that hides the surrounding

Currently CONFIG_COMPAT_32BIT_TIME is used only as a subset
of CONFIG_COMPAT, and the plan was to have 32-bit architectures
enable it later so they could get access to all the functions
implementing 32-bit time with a patch similar to what I'm testing
with, see for the current draft that
I use for testing.

We already spent several review rounds coming just discussing the
naming of the macros etc before we decided on the
symbol, but if you have a better suggestion (as part of moving
away from the compat_ naming), we can change all that again.


Powered by blists - more mailing lists