lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jul 2018 09:31:52 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Andy Lutomirski <luto@...capital.net> Cc: David Howells <dhowells@...hat.com>, Andrew Lutomirski <luto@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, Linux API <linux-api@...r.kernel.org>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Jann Horn <jannh@...gle.com>, Tycho Andersen <tycho@...ho.ws> Subject: Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9] On Thu, Jul 12, 2018 at 9:23 AM Andy Lutomirski <luto@...capital.net> wrote: > > (Al- can’t we just stop allowing splice() at all on things that don’t use iov_iter?) We could add a FMODE_SPLICE_READ/WRITE bit, and let people opt in to splice. We probably should have. But again, that really doesn't change the fundamentals. Using write() for commands is stupid. It also means that you have to _parse_ all the damn input at that level, which is a mistake too. It easily leads to insane decisions like "you have to use 'write()' calls without buffering", because re-buffering the stream is a f*cking pain. Just say no. Seriously. Stop this idiotic discussion. I'm just happy this came up early, because that way I know to look out for it and not merge it. Linus
Powered by blists - more mailing lists