linux-kernel - Re: [patch 3/7] x86/kvmclock: Decrapify kvm_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGM2rebCvhXrRZq9Cg16ow0+N8AE6Yvou5cF9yuP__t=sePpYQ@mail.gmail.com>
Date:   Wed, 11 Jul 2018 22:24:24 -0400
From:   Pavel Tatashin <pasha.tatashin@...cle.com>
To:     tglx@...utronix.de
Cc:     LKML <linux-kernel@...r.kernel.org>, pbonzini@...hat.com,
        rkrcmar@...hat.com, peterz@...radead.org, jgross@...e.com,
        Steven Sistare <steven.sistare@...cle.com>,
        Daniel Jordan <daniel.m.jordan@...cle.com>, x86@...nel.org,
        kvm@...r.kernel.org
Subject: Re: [patch 3/7] x86/kvmclock: Decrapify kvm_register_clock()

In addition to what Paolo's noticed, may be change printk to pr_info()
while editing around it:

> -
>         printk(KERN_INFO "kvm-clock: Using msrs %x and %x",
>                 msr_kvm_system_time, msr_kvm_wall_clock);
>
> +       hv_clock = (struct pvclock_vsyscall_time_info *)hv_clock_mem;
> +       kvm_register_clock("primary cpu clock");

Otherwise,
Reviewed-by: Pavel Tatashin <pasha.tatashin@...cle.com>