lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jul 2018 10:10:29 -0700 From: Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com> To: Brendan Higgins <brendanhiggins@...gle.com>, joe@...ches.com Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>, linux-i2c@...r.kernel.org, OpenBMC Maillist <openbmc@...ts.ozlabs.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, linux-aspeed@...ts.ozlabs.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, jarkko.nikula@...ux.intel.com, james.feist@...ux.intel.com, vernon.mauery@...ux.intel.com Subject: Re: [PATCH] i2c: aspeed: Add newline characters into message printings. On 7/12/2018 1:38 AM, Brendan Higgins wrote: > On Wed, Jul 11, 2018 at 10:10 AM Joe Perches <joe@...ches.com> wrote: >> >> On Wed, 2018-07-11 at 09:53 -0700, Jae Hyun Yoo wrote: >>> On 7/10/2018 10:42 PM, Brendan Higgins wrote: >>>> On Mon, Jul 2, 2018 at 2:14 PM Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com> wrote: >>>>> There are some log printing without a newline character. This >>>>> patch adds the missing newline characters. >> [] >>>>> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c >> [] >>>>> @@ -431,7 +431,7 @@ static bool aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus) >>>>> */ >>>>> if (bus->master_state == ASPEED_I2C_MASTER_START) { >>>>> if (unlikely(!(irq_status & ASPEED_I2CD_INTR_TX_ACK))) { >>>>> - pr_devel("no slave present at %02x", msg->addr); >>>>> + pr_devel("no slave present at %02x\n", msg->addr); >>>> >>>> Unless something changed in the last couple versions of the kernel, this is the >>>> only line that actually changes anything. dev_* inserts a newline for every >>>> call. >> >> Not true. >> >> Any printk without KERN_CONT inserts a newline >> if the last character >> emitted is not a newline. >> >> dev_<level> uses can also be followed by pr_cont. >> >> So this patch does reduce the possibility of >> interleaved messages from multiple processes. > > My mistake. Thanks for pointing that out. > > Jae, forget what I said earlier. This looks good to me. > Okay. I'll keep this patch as is. Thanks Joe for your clarification! Thanks Brendan for your 'Reviewed-by' tag! Jae
Powered by blists - more mailing lists