linux-kernel - Re: [PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180712195317.GA28761@kroah.com>
Date:   Thu, 12 Jul 2018 21:53:17 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Felix Siegel <felix.siegel@...teo.de>
Cc:     devel@...verdev.osuosl.org, John Joseph <jnjoseph@...gle.com>,
        linux-kernel@...r.kernel.org, Rob Springer <rspringer@...gle.com>
Subject: Re: [PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded
 string - Style

On Thu, Jul 12, 2018 at 09:27:15PM +0200, Felix Siegel wrote:
> Changed logging statements to use %s and __func__ instead of hard coding
> the function name in a string.
> 
> Signed-off-by: Felix Siegel <felix.siegel@...teo.de>
> ---
>  drivers/staging/gasket/apex_driver.c       | 15 ++++++++-------
>  drivers/staging/gasket/gasket_core.c       | 11 ++++++-----
>  drivers/staging/gasket/gasket_ioctl.c      |  4 ++--
>  drivers/staging/gasket/gasket_page_table.c | 13 ++++++++-----
>  4 files changed, 24 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
> index ffcc59d..735d43d 100644
> --- a/drivers/staging/gasket/apex_driver.c
> +++ b/drivers/staging/gasket/apex_driver.c
> @@ -341,7 +341,7 @@ static int apex_add_dev_cb(struct gasket_dev *gasket_dev)
>  	ulong page_table_ready, msix_table_ready;
>  	int retries = 0;
>  
> -	gasket_log_error(gasket_dev, "apex_add_dev_cb.");
> +	gasket_log_error(gasket_dev, "%s.", __func__);

Function calls that do nothing but log "Look at this function I just
entered/exited!" need to just be deleted entirely, as ftrace should be
used instead.

Care to do that here, and then send a patch for the remaining messages
that do need __func__?

thanks,

greg k-h