linux-kernel - Re: [PATCH v4 0/3] uio: fix potential crash bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c0ae0c9-2af6-c7c3-49b0-24302584a24d@alliedtelesis.co.nz>
Date:   Thu, 12 Jul 2018 20:34:53 +0000
From:   Hamish Martin <Hamish.Martin@...iedtelesis.co.nz>
To:     "xiubli@...hat.com" <xiubli@...hat.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "jannh@...gle.com" <jannh@...gle.com>,
        "pkalever@...hat.com" <pkalever@...hat.com>,
        "pkarampu@...hat.com" <pkarampu@...hat.com>,
        "atumball@...hat.com" <atumball@...hat.com>,
        "sabose@...hat.com" <sabose@...hat.com>,
        "mchristi@...hat.com" <mchristi@...hat.com>
Subject: Re: [PATCH v4 0/3] uio: fix potential crash bug

Hi Xiubo,

Tested-by: Hamish Martin <hamish.martin@...iedtelesis.co.nz>

I see these were already merged into Linus' tree but I wanted to let you 
know that I tested v4.18-rc4 (which contains these three patches) and 
the issue which led to my original series is still fixed and this patch 
series of yours has caused no regression in our scenario. This was 
tested on PPC 64 bit system (NXP T2081).

Thanks for resolving that.

Regards,
Hamish M.

On 07/07/2018 02:05 PM, xiubli@...hat.com wrote:
> From: Xiubo Li <xiubli@...hat.com>
>
> V2:
> - resend it with some small fix
>
> V3:
> - switch to use request_threaded_irq
>
> V4:
> - remove useless checking code, Thanks Mike.
> - Thanks very much for the review from Hamish and Mike.
>
>
> Xiubo Li (3):
>    uio: use request_threaded_irq instead
>    uio: change to use the mutex lock instead of the spin lock
>    uio: fix crash after the device is unregistered
>
>   drivers/uio/uio.c          | 139 +++++++++++++++++++++++++++++++++------------
>   include/linux/uio_driver.h |   2 +-
>   2 files changed, 104 insertions(+), 37 deletions(-)
>