linux-kernel - [PATCH] f2fs: hide unused procfs helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180713035304.18520-1-yuehaibing@huawei.com>
Date:   Fri, 13 Jul 2018 11:53:04 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <jaegeuk@...nel.org>, <yuchao0@...wei.com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH] f2fs: hide unused procfs helpers

When CONFIG_PROC_FS isn't set, gcc warning this:

fs/f2fs/sysfs.c:519:12: warning: ‘segment_info_seq_show’ defined but not used [-Wunused-function]
 static int segment_info_seq_show(struct seq_file *seq, void *offset)
            ^
fs/f2fs/sysfs.c:546:12: warning: ‘segment_bits_seq_show’ defined but not used [-Wunused-function]
 static int segment_bits_seq_show(struct seq_file *seq, void *offset)
            ^
fs/f2fs/sysfs.c:570:12: warning: ‘iostat_info_seq_show’ defined but not used [-Wunused-function]
 static int iostat_info_seq_show(struct seq_file *seq, void *offset)

We can fix the warning by adding the same #ifdef around them.

Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 fs/f2fs/sysfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index 2e7e611..7d45e65 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -516,6 +516,7 @@ static struct kobject f2fs_feat = {
 	.kset	= &f2fs_kset,
 };
 
+#ifdef CONFIG_PROC_FS
 static int segment_info_seq_show(struct seq_file *seq, void *offset)
 {
 	struct super_block *sb = seq->private;
@@ -608,6 +609,7 @@ static int iostat_info_seq_show(struct seq_file *seq, void *offset)
 
 	return 0;
 }
+#endif
 
 int __init f2fs_init_sysfs(void)
 {
-- 
2.7.0