linux-kernel - Re: [PATCH] connector: hide unused procfs helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9d2c823-56c3-b861-b56f-1ea83491e26a@huawei.com>
Date:   Fri, 13 Jul 2018 17:31:21 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <zbr@...emap.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] connector: hide unused procfs helpers

pls ignore this,my bad.

On 2018/7/13 15:11, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
> 
> drivers/connector/connector.c:242:12: warning: ‘cn_proc_show’ defined but not used [-Wunused-function]
>  static int cn_proc_show(struct seq_file *m, void *v)
>             ^
> fix this by adding #ifdef around it.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/connector/connector.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
> index e718b8c..e2636d4 100644
> --- a/drivers/connector/connector.c
> +++ b/drivers/connector/connector.c
> @@ -239,6 +239,7 @@ void cn_del_callback(struct cb_id *id)
>  }
>  EXPORT_SYMBOL_GPL(cn_del_callback);
>  
> +#ifdef CONFIG_PROC_FS
>  static int cn_proc_show(struct seq_file *m, void *v)
>  {
>  	struct cn_queue_dev *dev = cdev.cbdev;
> @@ -259,6 +260,7 @@ static int cn_proc_show(struct seq_file *m, void *v)
>  
>  	return 0;
>  }
> +#endif
>  
>  static struct cn_dev cdev = {
>  	.input   = cn_rx_skb,
>