linux-kernel - Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc410321-5dfd-7c26-2a3e-d2b2840da214@microchip.com>
Date:   Fri, 13 Jul 2018 12:56:22 +0300
From:   Radu Pirea <radu.pirea@...rochip.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <lee.jones@...aro.org>, <richard.genoud@...il.com>,
        <robh+dt@...nel.org>, <mark.rutland@....com>,
        <gregkh@...uxfoundation.org>, <linux-spi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi



On 07/10/2018 09:15 PM, Mark Brown wrote:
> On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote:
> 
> This is mostly good, just a couple of small things:
> 
>> +config SPI_AT91_USART
>> +	tristate "Atmel USART Controller SPI driver"
>> +	depends on HAS_DMA
>> +	depends on (ARCH_AT91 || COMPILE_TEST)
>> +	select MFD_AT91_USART
> 
> Why is this selecting rather than depending on the MFD like we normally
> do?
> 

Hi Mark,

If I add depends instead of select, current defconfigs will be broken 
and the proper driver will not be selected. Like this, there is no 
required change in any defconfig. Selecting the serial or spi driver 
from menuconfig makes the MFD completely transparent.
>> @@ -0,0 +1,432 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Driver for AT91 USART Controllers as SPI
>> + *
>> + * Copyright (C) 2018 Microchip Technology Inc.
>> + * Author: Radu Pirea <radu.pirea@...rochip.com>
>> + */
> 
> Please use C++ comments for the whole block so it looks a bit more
> intentional.

Ok. I will change it.

> 
> Otherwise
> 
> Reviwed-by: Mark Brown <broonie@...nel.org>
>