linux-kernel - Re: [PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180713112628.GA656@xux707-tw>
Date:   Fri, 13 Jul 2018 12:26:30 +0100
From:   John Whitmore <arigead@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        kstewart@...uxfoundation.org, keescook@...omium.org,
        aastha.gupta4104@...il.com, pombredanne@...b.com,
        tglx@...utronix.de
Subject: Re: [PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel
 case - Coding Style

On Fri, Jul 13, 2018 at 11:39:38AM +0200, Greg KH wrote:
> On Wed, Jul 11, 2018 at 08:21:43PM +0100, John Whitmore wrote:
> > Simple rename of the preprosessor switch, protecting against multiple
> > inclusion of the header file. Change to clear the checkpatch coding style
> > issue.
> > 
> > Signed-off-by: John Whitmore <johnfwhitmore@...il.com>
> > ---
> >  drivers/staging/rtl8192u/r8192U.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
> > index a653a51f7b90..86cf3ef3a970 100644
> > --- a/drivers/staging/rtl8192u/r8192U.h
> > +++ b/drivers/staging/rtl8192u/r8192U.h
> > @@ -15,8 +15,8 @@
> >   * project Authors.
> >   */
> >  
> > -#ifndef R819xU_H
> > -#define R819xU_H
> > +#ifndef R819U_H
> > +#define R819U_H
> 
> Shouldn't this be R8192U_H?
> 
> thanks,
> 
> greg k-h

Yes definately. I had another series of minor changes ready to go, so I just
tacked this change onto the end again.

jwhitmore