linux-kernel - Re: [PATCH] [v2] bcache: stop using the deprecated get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83724892-de0f-40ff-e16a-792a90d77ff1@suse.de>
Date:   Fri, 13 Jul 2018 23:34:55 +0800
From:   Coly Li <colyli@...e.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Kent Overstreet <kent.overstreet@...il.com>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Jens Axboe <axboe@...nel.dk>, Michael Lyle <mlyle@...e.org>,
        Tang Junhui <tang.junhui@....com.cn>,
        Hannes Reinecke <hare@...e.com>, linux-bcache@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] bcache: stop using the deprecated get_seconds()

On 2018/7/13 10:20 PM, Arnd Bergmann wrote:
> On Sat, Jun 23, 2018 at 10:12 AM, Coly Li <colyli@...e.de> wrote:
>> On 2018/6/22 9:48 PM, Arnd Bergmann wrote:
>>> The get_seconds function is deprecated now since it returns a 32-bit
>>> value that will eventually overflow, and we are replacing it throughout
>>> the kernel with ktime_get_seconds() or ktime_get_real_seconds() that
>>> return a time64_t.
>>>
>>> bcache uses get_seconds() to read the current system time and store it in
>>> the superblock as well as in uuid_entry structures that are user visible.
>>>
>>> Unfortunately, the two structures in are still limited to 32 bits, so this
>>> won't fix any real problems but will still overflow in year 2106. Let's
>>> at least document that properly, in case we get an updated format in the
>>> future it can be fixed. We still have a long time before the overflow
>>> and checking the tools at https://github.com/koverstreet/bcache-tools
>>> reveals no access to any of them.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> Added to 4.19 for-next.
> 
> I noticed this isn't part of linux-next (yet). Did it get dropped?
> 
>       Arnd
> 
Hi Arnd,

It is here,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/bcache-patches.git/tree/for-next/0004-bcache-stop-using-the-deprecated-get_seconds.patch

It is for Linux v4.19, the merge window is not available yet, and I
don't post them to Jens yet.

Thanks.

Coly Li