linux-kernel - Re: [PATCH] clk: imx6ul: fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180713164110.GA27943@osadl.at>
Date:   Fri, 13 Jul 2018 16:41:10 +0000
From:   Nicholas Mc Guire <der.herr@...r.at>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Nicholas Mc Guire <hofrat@...dl.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Frank Li <Frank.Li@...escale.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clk: imx6ul: fix missing of_node_put()

On Fri, Jul 13, 2018 at 09:27:30AM -0700, Stephen Boyd wrote:
> Quoting Nicholas Mc Guire (2018-07-13 04:13:20)
> > of_find_compatible_node() is returning a device node with refcount
> > incremented and must be explicitly decremented after the last use
> > which is right after the us in of_iomap() here.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> > Fixes: commit 787b4271a6a0 ("clk: imx: add imx6ul clk tree support")
> 
> This is not how a Fixes line works. It doesn't have 'commit'. I'll
> remove it when applying so no need to resend.
>
sorry - guess I got that wrong on a whole set of patches - fill fix that
for future patches and thanks for fixing it here 

thx!
hofrat